D25861: [Notifications] Fix crash accessing ViewTransition attached property

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There's something really funky going on in this...
  Avoid using `ViewTransition` attached property be just setting the animation target before triggering the model removal.
  
  BUG: 414066

TEST PLAN
  - Remains to be seen whether the crash is gone but gdb showed it was related to `QQuickViewTransitionAttached` which we no longer use
  - Hasn't crashed for a while lol

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25861

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191210/4d9bfde3/attachment-0001.html>