D24070: Don't use toolTipMainText to show info, rather use the second line
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Dec 10 09:23:54 GMT 2019
broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> broulik wrote in batterymonitor.qml:56
> You can probably just return `plasmoid.title` in the default case.
> Also, what's the reason for not showing percentage when power management is disabled? This isn't about the service not running or being a desktop PC, this is true when screens are forced on.
You still haven't addressed this. Don't just `return` when `powermanagementDisabled`, I would still want to see my battery state when this is the case?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24070
To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191210/7ecfdfac/attachment-0001.html>
More information about the Plasma-devel
mailing list