D25449: Start of the new Formats KCM

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> Messages.sh:2
>  #! /usr/bin/env bash
> -$EXTRACTRC *.ui >> rc.cpp
> -$XGETTEXT *.cpp -o $podir/kcmformats.pot
> +$EXTRACTRC `find . -name "*.ui"` >> rc.cpp || exit 11
> +$XGETTEXT `find . -name "*.cpp"` -o $podir/kcm5_formats.pot

this should say qml  somewhere?

> README:1
> +Plasma KCM Template
> +----------------------

not relevant

> formatssettings.kcfg:2
> +<?xml version="1.0" encoding="UTF-8"?>
> +<kcfg xmlns="http://www.kde.org/standards/kcfg/1.0"
> +      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

ooh, nice

> localemodel.cpp:15
> +    // Ensure that the "Default (C)" locale always appears at the top
> +    if (c1.name()== QLatin1Char('C') && c2.name()!=QLatin1String("C")) return true;
> +    if (c2.name()== QLatin1Char('C')) return false;

c1 == QLocale::c()

might be better than comparing names?

> localemodel.h:29
> +    Q_INVOKABLE int indexFor(const QString& value) const;
> +    Q_INVOKABLE QString valueFor(int idx) const;
> +private:

this is duplicating data()  no?

> main.qml:117
> +            currentIndex: kcm.model.indexFor(kcm.settings.lC_REGION)
> +            onCurrentIndexChanged: {
> +                kcm.settings.lC_REGION = kcm.model.valueFor(currentIndex)

there's another signal should be used

onActivated or sth that only includes user updates

> metadata.desktop:3
> +Name=Formats
> +Comment=what your app does in a few words
> +Icon=Plasma

->

> metadata.desktop:12-15
> +X-KDE-ServiceTypes=Plasma/Generic
> +X-Plasma-API=declarativeappletscript
> +
> +X-Plasma-MainScript=ui/main.qml

All of these 3 lines are wrong

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191206/907b6d0f/attachment-0001.html>