D25782: [Notifications] Add draggable file icon when single file job finishes
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Dec 6 11:56:35 GMT 2019
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This adds a file icon to a finished job for a single total file which can be dragged anywhere for convenience.
TEST PLAN
Often I download a file and then want to send it to someone, so being able to drag it off the notification similar to how you can do it with the screenshot notification is super useful.
The button glows on hover and has the open hand cursor to indicate it can be dragged
F7802057: Screenshot_20191206_125415.png <https://phabricator.kde.org/F7802057>
Clicking it opens the file and right click opens a file context menu. It is kinda redundant with the "Open" and menu button but I think something that looks like a file should be have like a file and those visual actions should be kept for accessibility.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25782
AFFECTED FILES
applets/notifications/notificationapplet.cpp
applets/notifications/notificationapplet.h
applets/notifications/package/contents/ui/JobItem.qml
applets/notifications/package/contents/ui/NotificationItem.qml
applets/notifications/package/contents/ui/main.qml
To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191206/7f084255/attachment.html>
More information about the Plasma-devel
mailing list