D25780: [Notifications] Set total amount to processed amount if no total and no error
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Dec 6 08:29:33 GMT 2019
broulik created this revision.
broulik added reviewers: Plasma, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Some jobs only set a processed amount and no total. This patch ensures when the job finishes, the total amount at least matches the processed amount.
The UI handles 1 out of 0 gracefully (only shows "1 file") but only if there is 1 total file will it offer to open the file.
TEST PLAN
5.17
The job should probably be fixed but I've seen others (I think trash job) also not doing it properly
- Sent a file from KDE Connect to my PC, got "Open" offered for that file
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25780
AFFECTED FILES
libnotificationmanager/job_p.cpp
To: broulik, #plasma, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191206/1333f510/attachment.html>
More information about the Plasma-devel
mailing list