D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

David Edmundson noreply at phabricator.kde.org
Fri Dec 6 06:34:29 GMT 2019


davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:93
> +                // FIXME: this doesn't work; it's always invisible
> +                visible: (monitor.State == Baloo.Baloo.FirstRun ||
> +                            monitor.State == Baloo.Baloo.NewFiles ||

Monitor's property is called state. Lowercase S.

A switch statement here might make this a bit easier to read.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191206/0d675083/attachment-0001.html>


More information about the Plasma-devel mailing list