D5346: DigitalClock: Use correct language for month and day names
David Edmundson
noreply at phabricator.kde.org
Thu Dec 5 21:27:13 GMT 2019
davidedmundson added a comment.
The thing this fixes is there.
It's arguably a tiny bit less relevant as people might now use a custom date format in just the digital clock, instead of choosing a different locale for times.
FWIW, I submitted a change that did exactly this at the "correct" layer in Qt: https://codereview.qt-project.org/c/qt/qtbase/+/139295
This is doing the same thing but with a parsing layer before we do the parsing....which is both really clever and horrificly mad at the same time.
The solution won't work in all cases. For example:
QLocale(QLocale::Portuguese).dateFormat() = "dddd, d 'de' MMMM 'de' yyyy"
So with this, if I have English language with portuguese time locale I still get "Thursday, 29 de October de 2015". which is still wrong.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5346
To: drosca, #plasma, mck182
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191205/72f33470/attachment.html>
More information about the Plasma-devel
mailing list