D24866: Wired setting: improve handling of link negotiation

Jan Grulich noreply at phabricator.kde.org
Thu Dec 5 14:42:44 GMT 2019


jgrulich marked an inline comment as done.
jgrulich added inline comments.

INLINE COMMENTS

> davidedmundson wrote in wiredconnectionwidget.cpp:79
> can loadConfig can be called multiple times?
> 
> If so we need an explicit
> 
>   else {
>    setCurrentIndex(LinkNegotiation::Ignore);
>   }

No, it cannot be called multiple times.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  ethernet-changes

REVISION DETAIL
  https://phabricator.kde.org/D24866

To: jgrulich, #plasma, #vdg, davidedmundson
Cc: davidedmundson, devurandom, ngraham, dvalter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191205/3a589bc3/attachment.html>


More information about the Plasma-devel mailing list