D25759: Do not crash when icon's source is empty

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Kirigami gallery would crash on the overlay sheet page due to trying
  to access m_theme which is a nullptr if setSource was never called.
  Since trying to render an icon with an empty source does not make
  much sense, just return when source is empty.

TEST PLAN
  Kirigami Gallery no longer crashes on the overlay sheet page.

REPOSITORY
  R169 Kirigami

BRANCH
  iconcrash

REVISION DETAIL
  https://phabricator.kde.org/D25759

AFFECTED FILES
  src/icon.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191205/bbac16dd/attachment.html>