D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> main.cpp:93
>      KConfigGroup startupConfGroup(startupConf, "Shell");
> -    const QString defaultShell = startupConfGroup.readEntry("ShellPackage", "org.kde.plasma.desktop");
> +    const QString defaultShell = startupConfGroup.readEntry("ShellPackage", qEnvironmentVariable("PLASMA_DEFAULT_SHELL", "org.kde.plasma.desktop"));
>  

I am bit unsure about this. We can simply write a configuration file in /etc/xdg using the plasma-phone-settings package.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah, mart, davidedmundson
Cc: mart, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191205/60afc1f0/attachment.html>