D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

Nathaniel Graham noreply at phabricator.kde.org
Wed Dec 4 17:43:11 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> IconMode.cpp:144
> +    // avoid double titles by setting the right face type before loading the module
> +    if ( d->categoryView->model()->rowCount(activeModule) > 1) {
> +        d->moduleView->setFaceType(KPageView::List);

pedantic nitpick: space before the final `)`

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191204/3e0836e5/attachment.html>


More information about the Plasma-devel mailing list