D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs
Nathaniel Graham
noreply at phabricator.kde.org
Wed Dec 4 14:45:21 GMT 2019
ngraham added inline comments.
INLINE COMMENTS
> IconMode.cpp:144
> + // avoid double titles by setting the right face type before loading the module
> + const int categoryCount = d->categoryView->model()->rowCount(activeModule);
> +
Since this is only used once, you don't really need to define a variable to hold it; just use it directly in the `if` statement.
REPOSITORY
R124 System Settings
BRANCH
no-double-titles (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25726
To: filipf, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191204/87819fe2/attachment-0001.html>
More information about the Plasma-devel
mailing list