D25740: Add item spacing to size hint

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Dec 4 13:51:10 GMT 2019


broulik created this revision.
broulik added reviewers: ndavis, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is what Adwaita Qt does [1] and it fixes the popup text being elided in Krita's filter popup with D25739 <https://phabricator.kde.org/D25739>
  
  [1] https://github.com/FedoraQt/adwaita-qt/blob/master/style/adwaitastyle.cpp#L2856

TEST PLAN
  5.17?
  
  - Other comboboxes look unchanged because iirc it only uses that size hint for the popup contents in SH_ComboBoxPopup mode, not in the default case we have in Breeze usually
  
  Before
  F7798929: Screenshot_20191204_145032.png <https://phabricator.kde.org/F7798929>
  After
  F7798925: Screenshot_20191204_144508.png <https://phabricator.kde.org/F7798925>

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25740

AFFECTED FILES
  kstyle/breezestyle.cpp

To: broulik, ndavis, hpereiradacosta
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191204/8f2f44a5/attachment.html>


More information about the Plasma-devel mailing list