D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Oh, well done! 
  I'd seen the bug report but hadn't been able to fix it.

INLINE COMMENTS

> IconMode.cpp:119
>      d->categoryView = nullptr;
> +    moduleView()->setFaceType(KPageView::Plain);
>  }

In general we want to not mix two styles in the same method.

The rest of the code uses
d->moduleView->

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191204/b4de1b09/attachment.html>