D23620: Fix speaker test not showing sinks/buttons

Nicolas Fella noreply at phabricator.kde.org
Sat Aug 31 23:24:35 BST 2019


nicolasfella created this revision.
nicolasfella added reviewers: Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Initially no sink is selected in the combobox which leads to an empty speaker test widget. Furthermore, when only one sink is available the combobox isn't shown at all, resulting in the speaker test not working because currentIndex will be -1.
  
  Fix this by setting the initial index to 0 and use 0 instead of -1 for querying model data when the combobox isn't shown

TEST PLAN
  With 1 available sink speaker test works. With two available sinks the first one is selected at startup, speaker test works

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  gix

REVISION DETAIL
  https://phabricator.kde.org/D23620

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190831/89e76478/attachment.html>


More information about the Plasma-devel mailing list