D23575: plasnoidviewer: restore support for --list & --list-themes

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Aug 30 16:39:47 BST 2019


kossebau abandoned this revision.
kossebau added a comment.


  Seems this whole implementation is not useful, as there is dedicated KPackage API to use instead (and which then could be used also from KDevelop itself) as well as is the question if this feature is wanted to be restored like this.
  
  Idea of this code dump was to help @apol on his plans to unbreak the Plasmoid launcher support in KDevelop, as I had this patch around locally from older times.
  So without being useful as is, and myself having other TODO things with more interest/priority, so will then dump the dump. :)

INLINE COMMENTS

> apol wrote in main.cpp:89
> QDir::NoDotAndDotDot.
> 
> Also you can use entryInfoList and avoid constructing the path inside.

Nice, was not aware of this flag. The place where I copied the code from and others I remember can be improved then as well.

> apol wrote in main.cpp:120
> qDebug? Or remove altogether.

Remove altogether?
But the whole idea of the method here is to get a list of the themes on stdout, to serve the "--list". Not sure what you mean here.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23575

To: kossebau, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190830/c6c2c64e/attachment-0001.html>


More information about the Plasma-devel mailing list