D23293: [Notifications] Implement JobViewV3

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> job_p.cpp:350
> +    auto it = properties.find(QStringLiteral("title"));
> +    if (it != end) {
> +        updateField(it->toString(), m_summary, &Job::summaryChanged);

you can probably constEnd / constFind etc.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23293

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190830/72e55eaa/attachment.html>