D23389: Use "Make default" buttons to switch the default device

Björn Feber noreply at phabricator.kde.org
Wed Aug 28 19:54:47 BST 2019


GB_2 added inline comments.

INLINE COMMENTS

> ListItemBase.qml:230
> +                    PlasmaComponents.Button {
> +                        text: PulseObject.default ? i18n("Default device") : i18n("Make Default")
> +                        iconName: PulseObject.default ? "favorite" : ""

"Default Device"

> ListItemBase.qml:231
> +                        text: PulseObject.default ? i18n("Default device") : i18n("Make Default")
> +                        iconName: PulseObject.default ? "favorite" : ""
> +                        enabled: !PulseObject.default

What about always showing the icon?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg, ndavis
Cc: GB_2, alexde, ndavis, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190828/ff4558c4/attachment-0001.html>


More information about the Plasma-devel mailing list