D23461: Remove 'magic' filtering of recent apps

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> recentusagemodel.cpp:522
> +        if (auto model = qobject_cast<InvalidAppsFilterProxy*>(sourceModel())) {
> +            model->setShowAllRecents(m_showAllRecents);
> +            m_showAllRecents = recents;

If this is called before refresh model will be null, and then we don't update m_showAllRecent

This needs to be outside the if statement.

Or you can simplify the whole thing and just use refresh()

> recentusagemodel.h:43
>      Q_OBJECT
> +    /* current kicker filters out recent apps that are also favorites, set this to true to bypass that */
> +    Q_PROPERTY(bool showAllRecents READ showAllRecents WRITE setShowAllRecents NOTIFY showAllRecentsChanged)

We can't say "Current kicker" as people will read this in the future.

I would write it as "filterFavourites" as that explains better what the opposite of showAll is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23461

To: tcanabrava, hein, davidedmundson
Cc: mart, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190828/b0a3225a/attachment-0001.html>