D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

Arjen Hiemstra noreply at phabricator.kde.org
Mon Aug 26 14:51:33 BST 2019


ahiemstra created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  When closing the menu of a PrivateActionToolButton with a click on the
  button, the checked state of the button would not properly clear. So
  instead use the button's toggled signal to handle menu open/close.
  Combined with a close policy where the parent is explicitly excluded we
  can properly clear the checked state.

REPOSITORY
  R169 Kirigami

BRANCH
  fix_actiontoolbutton

REVISION DETAIL
  https://phabricator.kde.org/D23463

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190826/492eda06/attachment.html>


More information about the Plasma-devel mailing list