D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

David Edmundson noreply at phabricator.kde.org
Mon Aug 26 11:23:35 BST 2019


davidedmundson added a comment.


  Generally seems ok. Two minor comments.

INLINE COMMENTS

> main.qml:238
> +                        _iconName: "edit-redo"
> +                        _text: i18nd("libplasma5", "Redo")
> +                        onTriggered: contextMenu.retFocus(() => mainTextArea.redo())

Where does this libplasma5 domain come from?

> documenthandler.cpp:94
>  
> +void DocumentHandler::paste()
> +{

This could  benefit from a name to explain the difference from the regular text edit paste.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190826/69f7fa2e/attachment.html>


More information about the Plasma-devel mailing list