D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

David Edmundson noreply at phabricator.kde.org
Mon Aug 26 10:30:05 BST 2019


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  :/ good catch.

INLINE COMMENTS

> startuptasksmodel.cpp:178
> +            // drop ".desktop" suffix
> +            appId.chop(8);
>  

I quite like doing

appId.chop(strlen(".desktop"))

then it's self documenting - strlen is magical and evaluates at compile time.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixsuffixchopping

REVISION DETAIL
  https://phabricator.kde.org/D23417

To: kossebau, hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190826/a014cf34/attachment.html>


More information about the Plasma-devel mailing list