D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#518001 <https://phabricator.kde.org/D23198#518001>, @dfaure wrote:
  
  > What I mean is:
  >
  > 1. improve KFileItem::isSlow to use this Solid code
  > 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true
  
  
  Sorry I misread you.
  
  > However maybe we don't want that in dolphin? Not sure. (In that case a new enum value can be added, to disable some features "if slow".)
  
  That could be a good idea, allowing users to prevent freezes.
  
  > In any case I see no reason for this code to be in recentusagemodel, it's just one out of many KFileItem users, with similar needs as most others.
  
  Yes I thought so, https://phabricator.kde.org/D23198#516506
  
  I really don't like the "isSlow" naming, it hides its meaning, network filesystem aren't necessarly slow, "isNetworkMounted" or similar would be more descriptive IMHO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190824/c312e306/attachment.html>