D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#517980 <https://phabricator.kde.org/D23198#517980>, @dfaure wrote:
  
  > Why not do this in KFileItem::isSlow() itself?
  >  (and enable SkipMimeTypeFromContent when isSlow is true)
  
  
  First because KFileItem::isSlow is a member function of KFileItem and this code is used to select the correct constructor of KFileItem in the first place...
  Second I already tried using KFileItem::isSlow method i.e KFileSystemType::fileSystemType and statvfs syscall in a previous attempt in this diff and it was not usable for this context :
  statvfs block the thread in case of a stale network mount until the network is back up (case of a nfs mounted when network is cut).
  Meaning it would freeze plasmashell when the case occurred, and shows that KFileItem::isSlow/KFileSystemType::fileSystemType cause freezes whenever they are used for a file on a network stale mount.
  
  This new method is actually implementing what I suggested in https://phabricator.kde.org/D19784#502503

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190824/c643e16e/attachment.html>