D23152: [energy kcm] Display Vendor and model

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in batterymodel.h:47
> As a cleanup measure (before or after, but separate of this patch), can you remove those separate invokables
> 
> 1. Add `Q_ENUM(Roles)`
> 2. `qmlRegisterUncreatableType` the `BatteryModel`
> 3. from QML use `data()` which is invokable since Qt 5.5 (after this code was written iirc):
> 
>   kcm.batteries.data(kcm.batteries.index(0, 0), BatteryModel.VendorRole)

I will do it as a followup.

> broulik wrote in main.qml:432
> Can you make this more generic, e.g.
> 
>   value = root["current" + uppercasefirst(modelData.source)]

Nice suggestion :)

REPOSITORY
  R102 KInfoCenter

BRANCH
  arcpatch-D23152

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190823/fbc4879d/attachment-0001.html>