D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart added a comment.


  when the intro page gets shown, (again binded from a bool property arriving from c++)
  categoryView.currentIndex should be set to -1,
  and systemsettings.activeCategory to -1 as well

INLINE COMMENTS

> SidebarMode.cpp:424
>  
> +void SidebarMode::showIntroPage()
> +{

this should be a bool property setter

> CategoriesPage.qml:43
>  
>              QQC2.ToolButton {
> +                id: showIntroPageButton

would be nice to have this disabled when on intro page.
the systemsettings context property should expose a bool property true when the intro page is shown

> CategoriesPage.qml:71
> +                id: menuButton
> +                icon.name: "application-menu"
> +                checkable: true

I would prefer overflow-menu

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190823/89d707cc/attachment-0001.html>