D23288: Move XResources out of the central model into a plugin

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Aug 20 16:46:43 BST 2019


apol added inline comments.

INLINE COMMENTS

> xres.cpp:1
> +#include "xres.h"
> +

What's the copyright?

> xres.cpp:6
> +#include <QGuiApplication>
> +#include <QtX11Extras/QX11Info>
> +

Scope shouldn't be necessary

> xres.h:1
> +#pragma once
> +

Copyright?

First time I see `#pragma once` in KDE software.

> ProcessModel.h:157
>              HeadingCommand,
> -            HeadingXMemory,
> +            HeadingXMemory, ///Deprecated. See plugins
>              HeadingXTitle,

if you pass 3/// you can just as well use `///<@deprecated. in xres plugin now`

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D23288

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190820/060952e1/attachment-0001.html>


More information about the Plasma-devel mailing list