D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

Nathaniel Graham noreply at phabricator.kde.org
Mon Aug 19 23:44:48 BST 2019


ngraham added a comment.


  In D23279#514843 <https://phabricator.kde.org/D23279#514843>, @davidedmundson wrote:
  
  > With this patch how would someone create the first new session?
  
  
  With Kickoff/kicker/dash/Krunner > Switch User, which goes directly to the session management screen.
  
  The comment in the code makes it clear that the current behavior of showing the button is a bug. If we decide that we like that behavior and do want it to be always shown, then it will be inappropriately invisible if `sessionsModel.showNewSessionEntry` is ever set to `false`, so something still needs to be fixed.
  
  Seems to me that we have two options:
  
  - Land this patch
  - Remove the `visible:` check entirely

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23279

To: ngraham, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190819/5e6e72b7/attachment.html>


More information about the Plasma-devel mailing list