D23261: Add option to discourage reporting bugs

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is for vendors and environments that don't want to allow their users to report bugs directly to us.
  By setting `InteractionAllowed` to `false` in `drkonqirc` the following will change:
  
  - For automatically restarted services, no hint is shown whatsoever
  - For application crashes a notification is shown with a Restart button but no status icon nor "Report bug" button
  
  The DrKonqi dialog itself is unchanged (for now?), which will show up in the rare case no notification service is running.

TEST PLAN
  Put the following in my ~/.config/drkonqirc
  
    [General]
    InteractionAllowed=false
  
  
  
  - Ran `killall -6 plasmashell`, plasmashell restarted without a trace
  - Ran `killall -6 dolphin`, Dolphin crashed, and I got a new notification. Successfully managed to restart Dolphin.
  
  F7260330: Screenshot_20190819_152501.png <https://phabricator.kde.org/F7260330>
  Old behavior with this setting to `true` (default) is unchanged
  
  - Verified that there are no stale `drkonqi` instances under any circumstances

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D23261

AFFECTED FILES
  src/main.cpp
  src/statusnotifier.cpp
  src/statusnotifier.h

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190819/a927b86d/attachment.html>