D23237: Do not display vendor, Product and capacity in network plasmoid

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Aug 19 09:48:03 BST 2019


broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  You cannot remove those from the dataengine, which is "Public API", there might be other users of that.
  Instead, remove them from the battery monitor UI. And while at it maybe show the details always even if there are multiple batteries.
  Capacity is also used in battery monitor to show a hint like "Your battery is broken"
  
  Also, this is not the network plasmoid but battery.
  Furthermore, I would appreciate if you could wait for maintainer approval before pushing changes that are clearly wrong.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23237

To: meven, ngraham, #plasma, broulik, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190819/e82a6902/attachment-0001.html>


More information about the Plasma-devel mailing list