D23253: [Notifications] Don't allow popup to obscure things in corners

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  One thing that has been bugging me a bit with notifications is how close the pop-up is
  to the screen corners/edges. It's so close that it obscures various things that live very
  close to screen edges, such as windows' titlebars and the text input field in chat apps.
  The latter case is really annoying in particular because if you have multiple chat apps
  running, notifications from the app that's in the background will obscure what you're
  typing in the text input field of the foreground chat app.
  
  This patch fixes these types of issues by doing the following:
  
  - Adjusting the popup positioning algorithm make popups that are in a corner equidistant from both adjacent screen edges, rather than only one
  - Doubling the defualt distance from the nearest corner/edge
  
  The combination of these changes allows pop-ups to no longer obscure window titlebars
  and chat windows' input fields.
  
  BUG: 401500
  FIXED-IN: 5.16.5

TEST PLAN
  Top corner popup position no longer obscures window titlebar text and buttons: F7259424: No longer obscures titlebar and windeco buttons.png <https://phabricator.kde.org/F7259424>
  Bottom corner popup position no longer obscures chat app's text input field: F7259425: No longer obscures what you're typing in a chat window.png <https://phabricator.kde.org/F7259425>

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification-popups-dont-obscure-things-in-corners0anymore (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23253

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: ngraham, broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190819/c147afe8/attachment.html>