D23250: Try to fix i18n() timing error in version strings
Nathaniel Graham
noreply at phabricator.kde.org
Mon Aug 19 00:48:30 BST 2019
ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Sometimes, `availableVersion` isn't set when the `i18n()` string is built, leading to ugly
"argument not found" errors. This is an attempt to fix it by not even using a localized
string anymore, since the only part of it that's really localizable is the direction of
the arrow. This is easy enough to toggle manually, so let's do that instead.
TEST PLAN
Hard to reproduce, but in my testing, it works, and the available version string is
empty until set, rather than showing a string formatting error.
REPOSITORY
R134 Discover Software Store
BRANCH
try-to-fix-i18n-timing-error (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D23250
AFFECTED FILES
discover/qml/UpdatesPage.qml
To: ngraham, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190818/a3f01888/attachment-0001.html>
More information about the Plasma-devel
mailing list