D23241: Show application window icon on AboutPage

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Aug 18 23:51:52 BST 2019


apol added a comment.


  +1 LGTM, please address the @since bit

INLINE COMMENTS

> settings.h:81
> +     */
> +    Q_PROPERTY(QVariant applicationWindowIcon READ applicationWindowIcon CONSTANT)
>  

It could make sense to include the REVISION part:
https://doc.qt.io/qt-5/properties.html

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23241

To: caspermeijn, mart, apol, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190818/31add0dd/attachment.html>


More information about the Plasma-devel mailing list