D17464: [Timer applet] Minor fixes for the applet

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  If it's the exact same code as before, then my opinion will be the same.
  
  The digital clock set the text height to 0.7 of the panel and the width is inferred through layouting.
  This patch sets the width based on the height of the parent. Which is why you need a different magic number.
  
  We adjust the layout with which in turn adjust the width which in turn adjusts the digitH..it's all very messy.
  
  Our best bet will be to fix the layouting, so that the width can be inferred automatically and you can use the same logic to set the height.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190817/55a36202/attachment.html>