D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Noah Davis]

ndavis added a comment.


  In D23169#513046 <https://phabricator.kde.org/D23169#513046>, @hpereiradacosta wrote:
  
  > Hi Noah
  >  Thanks for the patch, however, it is not the right fix to the issue. If you use a light color scheme (like the default breeze), you will see that the shadow below the part of the button that corresponds to the arrow is darker than below the rest of the button. This is because the frame is actually rendered twice.
  >
  > Now, the bug you try to fix is real, and as I was 100% sure that it was not there in the past, I used git bisect to track it down to this commit:
  >
  > 32d8b02880a237e6de415861500a018a5cd09781 <https://phabricator.kde.org/R31:32d8b02880a237e6de415861500a018a5cd09781>
  >
  > The corresponding diff contains 
  >  @@ -5988,7 +5988,6 @@ namespace Breeze
  >
  >   // frame
  >   if( toolButtonOption->subControls & SC_ToolButton )
  >   {
  >
  > - copy.rect = buttonRect; if( inTabBar ) drawTabBarPanelButtonToolPrimitive( &copy, painter, widget ); else drawPrimitive( PE_PanelButtonTool, &copy, painter, widget); }
  >
  >   Which is what causes the issue. Could you revert this commit, and push instead the proper fix that I will post in another comment ?
  >
  >   Alternatively, I can do it myself. Note that your changes on the separator position is legit, but should be a different patch
  
  
  Sure, thanks for the help.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190816/ae53fc39/attachment.html>