D23198: Skip mime type check only for files on network mounts
Méven Car
noreply at phabricator.kde.org
Fri Aug 16 17:27:35 BST 2019
meven added a comment.
In D23198#512999 <https://phabricator.kde.org/D23198#512999>, @ngraham wrote:
> In D23198#512942 <https://phabricator.kde.org/D23198#512942>, @broulik wrote:
>
> > `fileSystemType` calls `statvfs` which might also block, so I don't think this helps.
>
>
> True, but then that implies that `KFileItem::isSlow()` which has the same code is flawed in the same way.
Well I had the same reflection in https://phabricator.kde.org/D19784#503088 but after reflection it is ok :
A file whose filesystem is not mounted, is a non-existing file which statvfs report as its error ENOENT http://man7.org/linux/man-pages/man3/statvfs.3.html
I still have to test it at home where I have a nfs setup.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D23198
To: meven, #plasma, dfaure
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190816/42fae951/attachment.html>
More information about the Plasma-devel
mailing list