D22896: Port System Settings sidebar to QQC2

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> SettingsBase.cpp:143
>      configureAction = actionCollection()->addAction( KStandardAction::Preferences, QStringLiteral("configure"), this, SLOT(configShow()) );
>      actionCollection()->setDefaultShortcut(configureAction, QKeySequence(Qt::CTRL + Qt::Key_M));
> +    configureAction->setText( i18n("Configure...") );

lolwut

The default shortcut for "Configure" is [Ctrl] + [⇧] + [comma] these days!

I never even new this had a shortcut because only with your patch does it become visible. :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190815/db99250e/attachment-0001.html>