D23151: Implement Web Share API through Purpose

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> purposeplugin.cpp:127
> +        if (!text.isEmpty()) {
> +            urls.append(text);
> +        }

shouldn't this be a data: url or something like that? urls should only have urls

> purposeplugin.cpp:161
> +    if (!mimeType.isEmpty() && mimeType != QLatin1String("application/octet-stream")) {
> +        shareData.insert(QStringLiteral("mimeType"), mimeType);
> +    } else {

Passing application/octet-stream should work, maybe it's a bug in Purpose.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190814/03836d22/attachment.html>