D22053: [libtaskmanager] Track stacking order and window activation (on X11)

[David Edmundson]

davidedmundson added a comment.


  One minor comment, and anthonyfieroni's comment, and this is good to go.

INLINE COMMENTS

> xwindowtasksmodel.cpp:203
> +            cachedStackingOrder = KWindowSystem::stackingOrder();
> +            q->dataChanged(q->index(0, 0), q->index(q->rowCount() - 1, 0),
> +                QVector<int>{StackingOrder});

if (rowCount > 0) {

}

otherwise you emit data changed for an invalid index. I think it could happen as stacking order includes some windows not listed here and we have the xwindowsystemeventbatcher

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22053

To: hein, #plasma
Cc: davidedmundson, pino, anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190814/50b33dab/attachment-0001.html>