D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

Marco Martin noreply at phabricator.kde.org
Wed Aug 14 15:31:40 BST 2019


mart added inline comments.

INLINE COMMENTS

> Action.qml:27
>   *
>   * @inherit QtObject
>   */

@inherit QtQuick.Controls.Action

> Action.qml:76
>       */
> -    property ActionIconGroup icon: ActionIconGroup {
> -        id: iconGroup
> -    }
> +//     property ActionIconGroup icon: ActionIconGroup {
> +//         id: iconGroup

remove dead code

> Action.qml:152
>  
> -    property Shortcut __shortcut: Shortcut {
> -        property bool checked: false
> -        id: shortcutItem
> -        enabled: root.enabled
> -        onActivated: root.trigger();
> -    }
> -    function trigger(source) {
> -        if (!enabled) {
> -            return;
> -        }
> -        root.triggered(source);
> -        if (root.checkable) {
> -            root.checked = !root.checked;
> -            root.toggled(root.checked);
> -        }
> -    }
> -
> -    onCheckedChanged: root.toggled(root.checked);
> +//     property Shortcut __shortcut: Shortcut {
> +//         property bool checked: false

remove dead code

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22974

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190814/e8a01008/attachment.html>


More information about the Plasma-devel mailing list