D23099: Allow sending a port message and receive a reply

Fabian Vogt noreply at phabricator.kde.org
Tue Aug 13 10:51:22 BST 2019


fvogt added inline comments.

INLINE COMMENTS

> extension.js:109
>  
> -        if (!subsystem || !action) {
> +        if (replyToSerial < 0 && (!subsystem || !action)) {
>              return;

Would need to be `"replyToSerial" in message` now, `undefined` is not smaller than 0

> pluginmanager.cpp:132
> +        const auto reply = plugin->handleData(requestSerial, event, json);
> +        if (!reply.isEmpty()) {
> +            plugin->sendReply(requestSerial, reply);

Might be useful to always reply as ack?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23099

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190813/36cfdf1c/attachment.html>


More information about the Plasma-devel mailing list