D23049: Add Kirigami ListSectionHeader component

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ListSectionHeader.qml:92
> +
> +        Component.onCompleted: {
> +            for (var i = 0; i < customItems.length; i++) {

This is a no-go hack:
those customItems shouldn't be reparented, but rather the property should be an alias to the data of another layout, like:

  property alias customItems: innerLayout.data
  contentItem: RowLayout {
      id: rowLayout
      RowLayout {
          id: innerLayout
      }

or, i would prefer even more, to just ditch that extra property completely:

  default property alias _contents: rowLayout.data
  contentItem: RowLayout {

​   id: rowLayout
	​   Heading {

  ....

so one just does

  ListSectionHeader {
     Button {....}
  }

and just works(tm)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190813/3abedeab/attachment.html>