D23039: Make Kickoff restore favorites order when dragging an item to desktop

Nathaniel Graham noreply at phabricator.kde.org
Fri Aug 9 13:58:19 BST 2019


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, nice. #plasma <https://phabricator.kde.org/tag/plasma/> folks?

INLINE COMMENTS

> FavoritesView.qml:94
> +
> +        onDragLeave: {
> +            var source = kickoff.dragSource;

Could you add a comment explaining why this is done, for the benefit of people reading the code in the future?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23039

To: lisin, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190809/7b555914/attachment.html>


More information about the Plasma-devel mailing list