D23039: Make Kickoff restore favorites order when dragging an item to desktop

Konstantin Lisin noreply at phabricator.kde.org
Fri Aug 9 11:09:05 BST 2019


lisin added a comment.


  I was reluctant to introduce a new variable with such a broad scope (`kickoff.dragStartRow`) but using the `startRow` from `DropArea` would sometimes still mess up the order - the item would get the new value of `startRow` if the user moved the cursor back inside `DropArea`, so it would be snapping back to the wrong position. It's not really something a user would commonly do, so I can edit the code to use it instead. Otherwise, `startRow` wasn't used anywhere so I removed it completely.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23039

To: lisin, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190809/974a8255/attachment.html>


More information about the Plasma-devel mailing list