D23023: more control on what shell is loaded

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> main.cpp:91
>  
> +    QString defaultShell = qgetenv("KDE_PLASMA_SHELL");
> +    if (defaultShell.isEmpty()) {

MAY I SUGGEST RENAMING TO kde_plasma_shellpackage?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23023

To: mart, #plasma
Cc: bshah, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190808/411e1986/attachment.html>