D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> SidebarMode.cpp:570
>          emit changeToolBarItems(BaseMode::NoItems);
> +    } else if (watched->inherits("QWidgetWindow") && event->type() == QEvent::MouseButtonPress) {
> +        QMetaObject::invokeMethod(d->quickWidget->rootObject(), "closeMenu");

Not a huge fan of this.
Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and `ComboBox` popup?

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190808/24d628e5/attachment-0001.html>