D22988: Fix incorrect Kickoff tab bar layout for vertical panels

Eike Hein noreply at phabricator.kde.org
Thu Aug 8 03:44:58 BST 2019


hein added a comment.


  ... I'm not the author or maintainer of this code, but I had a look anyway :).
  
  @lisin, I agree with you that the sizing bug should be fixed in TabBar instead, in plasma-frameworks.git. It's very unorthodox to call a property change handler as a function, and it's not going to fix this for other potential users of the component.
  
  Otherwise the patch looks good. Could you resubmit it without line 435, and then submit a seperate patch to plasma-frameworks?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22988

To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190808/72442395/attachment.html>


More information about the Plasma-devel mailing list