D22844: [kcm-colors] Export colorscheme to GTK color definitions

[Arjen Hiemstra]

ahiemstra added a comment.


  Just a small thing I noticed when scrolling through the patch.

INLINE COMMENTS

> krdb.h:31
> +   KRdbExportGtkTheme    = 0x0010,   // Export KDE's widget style to Gtk if possible
> +   KRdbExportGtkColors   = 0x0012    // Export KDE's colors to Gtk if possible
>  };

Since this is treated as a flag, shouldn't this be 0x0020? Otherwise it would be equal to KRdbExportQtColors & KRdbExportGtkTheme which is probably not what you want.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma, ngraham
Cc: ahiemstra, ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190806/d163aec3/attachment.html>