D22945: Fix --replace option

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Aug 5 13:55:48 BST 2019


apol added inline comments.

INLINE COMMENTS

> broulik wrote in main.cpp:136
> Can you explain? The `ShellCorona` is parented to the app, so is destroyed with it. Is the `deleteLater` even still processed at this point?

aboutToQuit is called much earlier than the actual destruction.

> broulik wrote in main.cpp:182
> So this will just eat CPU until the other process quit?
> Can we register `org.kde.plasmashell` service with `AllowReplace` flag so the new process can just take over?

We can do this change if we get D22946 <https://phabricator.kde.org/D22946> in.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22945

To: apol
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190805/ab66bbd7/attachment-0001.html>


More information about the Plasma-devel mailing list