D22912: Fix build with clang 9.0

Bernhard Rosenkraenzer noreply at phabricator.kde.org
Sat Aug 3 21:51:40 BST 2019


bero created this revision.
bero added a reviewer: Latte Dock.
bero added a project: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bero requested review of this revision.

REVISION SUMMARY
  Without this patch, trying to build latte-dock with clang 9.0 results in:
  
  ../app/settings/delegates/persistentmenu.cpp:23:41: error: addition of default argument on redeclaration makes this constructor a default constructor
  PersistentMenu::PersistentMenu(QWidget *parent = 0)
  
    ^        ~
  
  ../app/settings/delegates/persistentmenu.h:31:3: note: previous declaration is here
  
    PersistentMenu(QWidget *parent);
    ^
  
  1 error generated.

TEST PLAN
  Install clang 9.0-rc1, try to build latte-dock, see if it succeeds

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D22912

AFFECTED FILES
  app/settings/delegates/persistentmenu.cpp
  app/settings/delegates/persistentmenu.h

To: bero, #latte_dock
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, niccolove, ragreen, Pitel, lavender, ZrenBot, himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190803/d3f4b8f8/attachment.html>


More information about the Plasma-devel mailing list